Skip to content

Fix incorrect grouped product qty returned in GraphQL due to hydration overwriting link attributes #40293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix incorrect grouped product qty returned in GraphQL due to hydration overwriting link attributes #40293

wants to merge 7 commits into from
+165 −6

Conversation

@mimou78
Copy link
Contributor

@mimou78 mimou78 commented Nov 16, 2025

Description

This pull request fixes an issue where GraphQL returns incorrect or inconsistent qty values for grouped product links.
During GraphQL hydration, the Product::getQty() value is overwritten because it represents a mutable runtime value rather than the original link attribute qty stored in the database.

This causes:

  • GraphQL to return wrong qty values (often 1)
  • REST API to return correct qty values
  • Multiple hydration passes to overwrite values in memory

This PR ensures that GraphQL consistently uses the original link quantity via getInitialQty() (or an equivalent stable fallback), preventing overwriting and ensuring parity between REST and GraphQL.

Related Pull Requests

None.

Fixed Issues

@m2-assistant
Copy link

m2-assistant bot commented Nov 16, 2025

Hi @mimou78. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@mimou78 mimou78 marked this pull request as draft November 16, 2025 20:09
@mimou78
Copy link
Contributor Author

mimou78 commented Nov 16, 2025

@magento run Unit Tests

@mimou78 mimou78 marked this pull request as ready for review November 16, 2025 20:17
@mimou78
Copy link
Contributor Author

mimou78 commented Nov 17, 2025

@magento run all tests

@mimou78
Copy link
Contributor Author

mimou78 commented Nov 18, 2025

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 18, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Nov 18, 2025
@mimou78
Copy link
Contributor Author

mimou78 commented Nov 21, 2025

@magento run Unit Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Pull Requests Dashboard
Status: Pending Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[GraphQl] Order of graphql request changes value for default qtys on grouped product.

2 participants

@mimou78 @engcom-Hotel